Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(fetch): readmeAPIFetch, consolidate base URL #742

Merged
merged 2 commits into from
Feb 1, 2023
Merged

refactor(fetch): readmeAPIFetch, consolidate base URL #742

merged 2 commits into from
Feb 1, 2023

Conversation

kanadgupta
Copy link
Member

@kanadgupta kanadgupta commented Feb 1, 2023 •
edited
Loading

🧰 Changes

Follow-up PR to #735 based on this feedback from @erunion: #735 (comment)

🧬 QA & Testing

No functional changes, just a lot of refactors. If the build and tests pass, we should be good to go!

@kanadgupta kanadgupta mentioned this pull request Feb 1, 2023
Merged
5 tasks
@kanadgupta kanadgupta added the refactor Issues about tackling technical debt label Feb 1, 2023
@kanadgupta kanadgupta marked this pull request as ready for review February 1, 2023 21:37
@kanadgupta kanadgupta requested a review from erunion February 1, 2023 21:37
@kanadgupta kanadgupta merged commit 452be3a into main Feb 1, 2023
@kanadgupta kanadgupta deleted the refactor/rename-fetch-wrapper branch February 1, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erunion erunion erunion approved these changes

Assignees
No one assigned
Labels
refactor Issues about tackling technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kanadgupta @erunion